- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migration to avoid duplicate collection slugs and names #2318
Merged
+58
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…ugs: - add unique slug index as part of migration - if duplicate slug detected, increment suffix until valid slug is found - also add suffix to original name, as names should also be unique - add unique name index as part of migration
tw4l
reviewed
Jan 21, 2025
tw4l
reviewed
Jan 21, 2025
tw4l
reviewed
Jan 21, 2025
Loading status checks…
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
tw4l
approved these changes
Jan 21, 2025
ikreymer
commented
Jan 21, 2025
Loading status checks…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2301
Updates the 0039 migration to ensure collection slugs and names are unique by:
slug
to random valueslug
field.slug_from_name()
-<counter>
at end of slug. Also update name with<counter>
.