Remove ANALYTICS_NAMESPACE, as it's only usable at build time #2293
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
force-pushed
the
public-collections-feature
branch
from
f06faa8 to
85053b8
Compare
SuaYoo
approved these changes
Jan 13, 2025
SuaYoo
force-pushed
the
public-collections-feature--analytics-namespace-runtime
branch
from
89eb82d to
867a33e
Compare
SuaYoo
force-pushed
the
public-collections-feature
branch
from
85053b8 to
56a634e
Compare
and replace it with a runtime window.btrixEvent set that can be set in the extra.js config
SuaYoo
force-pushed
the
public-collections-feature--analytics-namespace-runtime
branch
from
867a33e to
747f67c
Compare
SuaYoo
reviewed
Jan 14, 2025
| @@ -230,7 +230,7 @@ Note that the script will only run when the web app loads, i.e. the first time t | |||
|
|
|||
| ### Tracking events | |||
There was a problem hiding this comment.
Tweaked language in this section
SuaYoo
force-pushed
the
public-collections-feature--analytics-namespace-runtime
branch
from
493b5d1 to
37f3230
Compare
SuaYoo
deleted the
public-collections-feature--analytics-namespace-runtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaces
ANALYTICS_NAMESPACEwith settingwindow.btrixEventviainject_extraconfig.Tested locally with the
inject_extravalue in https://github.com/webrecorder/browsertrix-cloud-ops/pull/8.