-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix progress on line wrap (trim line to stderr.columns) #9225
Conversation
For maintainers only:
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
friendly bump |
Thanks |
With |
@kinke please open an issue if you think this caused a bug, closed PRs are not good for visibility. Also please mention the webpack version you're on. |
Well it's not a bug IMO, just a major inconvenience - I downgraded from v4.35.2 to v4.34 because of this. |
IMO falling back to |
fix #9221
fixed it by trimming lines to
process.stderr.columns
if it existsWhat kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
also added a test utility file so I didn't have to clutter up the
progressPlugin.test.js
, but it can be moved back in. I just needed a utility for capturingstderr
and promisifiedcompiler.run