[WIP] Fixes #5392. EnvironmentPlugin now extends process.env #8721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
I'm going to take a look at the failed tests |
|
The basic integration tests failed. @misterdev Please review the following output log for errors: See complete report here. |
|
I'm debugging this, I've seen the problem comes from the fact that the test has multiple configurations: module.exports = [
{
name: "aaa",
module: {
unknownContextRegExp: /$^/,
unknownContextCritical: false
},
plugins: [new EnvironmentPlugin("AAA")]
},
{
name: "bbbccc",
module: {
unknownContextRegExp: /$^/,
unknownContextCritical: false
},
plugins: [new EnvironmentPlugin("BBB", "CCC")]
}
]Seems like this starts multiple compilations concurrently, in fact running this configuration produces every time a different output, sometimes it prepends I'm going to investigate this tomorrow, any help/suggestion is welcome 👍 @evenstensberg could you explain what do you mean? |
|
similar issue resolved with quick json conversions. |
|
@misterdev Did you find a solution to solve this problem ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
EnvironmentPluginis just a shortcut to use theDefinePluginonprocess.envkeys (link).As pointed out in #5392 this doesn't work for object destructuring:
The problem is that the
DefinePlugincan't detect some edge case like:To solve this I add some code at the beginning of the output, that initializes the environment variables. For example, the result would be
I've tried different solutions but removing the
DefinePluginseems the cleanest way of solving this.This is my first contribution, every feedback is welcome 😇
What kind of change does this PR introduce?
This is a bugfix 🐛
Did you add tests for your changes?
If this seems the correct approach to solve the issue I'm going to add some tests
Does this PR introduce a breaking change?
I don't think so, now it actually adds some keys to the
process.envas you would expect.What needs to be documented once your changes are merged?
I need to update the EnvironmentPlugin documentation