Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update .editorconfig #18376

Closed
wants to merge 1 commit into from
Closed

chore: update .editorconfig #18376

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2024

What kind of change does this PR introduce?

Remove unnecessary code duplication in the .editorconfig file.

indent_size= 2 is already defined in the [ * ] section, so it is redundant to repeat it in the [*.{yml,yaml,json}] section.

Did you add tests for your changes?

no need

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

none

Copy link

linux-foundation-easycla bot commented May 1, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Hi @veamaral.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own main branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

Repository owner closed this by deleting the head repository May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants