fix: only render init code when need moduleRemapping #18338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
For
ExternalModule
, renderinit
code only when needingmoduleRemapping
, which will reduce useless code. Although theinit
code could be removed when minimizing, but this will help in some scenario, for example, we are using webpack to building bundleless package without running minimizing, this will help.Did you add tests for your changes?
No, the test code is not minimized, they should sufficient so far. Feel free to let me what kind of case should be added. :)
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?
No.