Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Type wrong.
Did you add tests for your changes?
The
resourcePath
,resourceQuery
, andresourceFragment
properties withinLoaderRunnerLoaderContext
may not be defined if a loader is invoked without an associated resource.For evidence of this behavior, refer to the test case located in
test/cases/loaders/query/index.js
. The test titled "should pass query to loader without resource" confirms this scenario.However, this behavior could lead to type errors for loaders written in TypeScript. To address this, the
loader-runner
can be updated to assign an empty string as a default value for these properties.Which plan do you think is better?
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?