Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace remaining RuntimeGlobals references #18121

Merged
merged 3 commits into from
Mar 13, 2024
Merged

chore: replace remaining RuntimeGlobals references #18121

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
704f0f4
chore: replace hardcoded regexp
tthijm Feb 27, 2024
927734f
chore: change globToRegex to RegExp
tthijm Feb 27, 2024
e20205c
chore: fix RegExp string
tthijm Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/DefinePlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

"use strict";

const globToRegex = require("glob-to-regexp");
const {
JAVASCRIPT_MODULE_TYPE_AUTO,
JAVASCRIPT_MODULE_TYPE_ESM,
Expand Down Expand Up @@ -308,8 +309,10 @@ const PLUGIN_NAME = "DefinePlugin";
const VALUE_DEP_PREFIX = `webpack/${PLUGIN_NAME} `;
const VALUE_DEP_MAIN = `webpack/${PLUGIN_NAME}_hash`;
const TYPEOF_OPERATOR_REGEXP = /^typeof\s+/;
const WEBPACK_REQUIRE_FUNCTION_REGEXP = /__webpack_require__\s*(!?\.)/;
const WEBPACK_REQUIRE_IDENTIFIER_REGEXP = /__webpack_require__/;
const WEBPACK_REQUIRE_FUNCTION_REGEXP = globToRegex(
RuntimeGlobals.requireScope
);
const WEBPACK_REQUIRE_IDENTIFIER_REGEXP = globToRegex(RuntimeGlobals.require);
tthijm marked this conversation as resolved.
Show resolved Hide resolved

class DefinePlugin {
/**
Expand Down