Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not mangle export with destructuring #18059

Merged

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Feb 6, 2024

fix #18013

What kind of change does this PR introduce?

fix not mangle the export when destructuring module's export.
when destructuring a module: let { export1 } = m, can't mangle the export1.
but when destructuring a module's export: let { a } = m.export1, can mangle the export1

Did you add tests for your changes?

added

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

none

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@ahabhgk ahabhgk force-pushed the fix-not-mangle-in-destructuring branch from 4c8296e to 0aaa497 Compare February 6, 2024 07:26
@ahabhgk ahabhgk marked this pull request as draft February 6, 2024 07:28
@ahabhgk ahabhgk force-pushed the fix-not-mangle-in-destructuring branch from 0aaa497 to c854b46 Compare February 6, 2024 08:34
@ahabhgk ahabhgk force-pushed the fix-not-mangle-in-destructuring branch from c854b46 to 69127ae Compare February 6, 2024 09:50
@ahabhgk ahabhgk marked this pull request as ready for review February 6, 2024 09:54
@alexander-akait alexander-akait merged commit 2a063f8 into webpack:main Feb 8, 2024
51 checks passed
@alexander-akait
Copy link
Member

Thank you

@ahabhgk ahabhgk deleted the fix-not-mangle-in-destructuring branch February 8, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

Exported object names not minified since 5.79
3 participants