Add tests for ModuleFilenameHelpers #17784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
mayankkamboj47
force-pushed
the
moduleFilenameHelpers
branch
from
5570309
to
98cb418
Compare
mayankkamboj47
force-pushed
the
moduleFilenameHelpers
branch
from
98cb418
to
0fc55b1
Compare
|
Could you please review this ? |
|
@mayankkamboj47 Can you fix CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #16851, add tests for ModuleFilenameHelpers. This PR only adds tests for functions behaving as expected. Refer to #16851 for details on others
Summary
馃 Generated by Copilot at b2262eb
This pull request improves the documentation and testing of the webpack project. It fixes some formatting and style issues in
_SETUP.md,CONTRIBUTING.md, andREADME.md, and adds a reference toSECURITY.mdin the contribution guidelines. It also adds unit tests for theModuleFilenameHelpersmodule intest/ModuleFilenameHelpers.test.js.Details
馃 Generated by Copilot at b2262eb
webpackinREADME.mdandCONTRIBUTING.mdfor consistency and branding (link, link, link, link, link)conceptspage inREADME.md(link)Reporting Security Issuessection fromSECURITY.mdtoCONTRIBUTING.mdto consolidate information for contributors (link)CONTRIBUTING.mdfor better readability (link, link)yarn lintcommand and remove duplicate code block in_SETUP.md(link, link)ModuleFilenameHelpersmodule intest/ModuleFilenameHelpers.test.js(link)