New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stats.hasWarnings() should respect ignoreWarnings #17690
fix: stats.hasWarnings() should respect ignoreWarnings #17690
Conversation
For maintainers only:
|
@alexander-akait Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with it, but I am afraid it can be a breaking change, because some tools can rely on this behaviour... I think we need a small dicussion here @webpack/core-support @webpack/cli-team
@alexander-akait Yeah, this could be a potential breaking change. I believe we should consider this change for webpack v6 |
I think this is valid, |
@vankop I think we need a test cases to prevent a regression in future |
Feel free to send it and we can merge it |
@nanianlisao Thanks for your update. I labeled the Pull Request so reviewers will review it again. @vankop Please review the new changes. |
Great, could you please take a look again. @alexander-akait |
Summary
Actually, I am not sure if this is a bug or if it was done intentionally. But I think
hasWarnings
instats
should respectignoreWarnings
。Especially in the compiler.hooks.done hooks, stats obtained is directly processed via hasWarnings to handle warnings.
🤖 Generated by Copilot at 345939a
Refactor
Stats.hasWarnings
to useCompilation.getWarnings
. This is part of a larger effort to optimize and enhance the stats output.Details
stats.hasWarnings()
should respectignoreWarnings
🤖 Generated by Copilot at 345939a
Compilation
class (0,10,10,1,F0L3R