fix: destructing assignment of dynamic import json file #17418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
alexander-akait
approved these changes
Dec 11, 2023
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #17042
Summary
馃 Generated by Copilot at 182f913
Fixed a tree-shaking bug for
defaultexports of JSON modules and added new test cases for dynamic imports withwebpackExportshint. The test cases cover various scenarios of importing JSON modules and other modules with destructuring assignment and named imports.Details
馃 Generated by Copilot at 182f913
defaultexport of non-tree-shakable modules was incorrectly tree-shaken when using destructuring assignment or named imports (link)test/cases/chunks/destructuring-assignmentandtest/cases/chunks/inline-optionsto cover the bug fix and thewebpackExportshint for JSON modules and modules withexportsType: "default"(link, link, link, link, link, link, link, link, link, link, link)