fix: modules being in wrong chunks #17103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
For maintainers only:
|
|
Seems, like we have more changes than should, and some of changes are not looks good, need do more deep investigation... |
|
Yup it's a bit of a mess... Will clean up |
bmarti44
force-pushed
the
fix-missing-modules
branch
from
d603153
to
c24604b
Compare
|
okay i found the exact line causing the issue for me - i'm a bit unfamiliar with the code but i'm reading through it now |
|
And can you provide list of plugins (maybe some of them do not allow webpack to drop them)? |
bmarti44
force-pushed
the
fix-missing-modules
branch
from
c24604b
to
76029ad
Compare
|
logged out everything for this condition -> at first glance, it appears that everything from the shared libraries i have in my node_modules folder is being printed out (here is a snippet) -> this goes on for many thousands of lines. as for files in my project (local looking at the stats, orphan modules seem to comprise most of my app ->
|
|
I'm going through plugins now and removing what I can, will see what effect this has... |
|
ugh oh no found the issue... if the mode is production, the ModuleConcatenationPlugin is already applied, which makes the extra ModuleConcatenationPlugin redundant and causing all sorts of chaos... closing this out, thank you so much for the help here! |
|
Great, we found a problem, hope it will help other too 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building my project outlined in #17059 certain modules are being removed or added to the incorrect chunk (I am not 100% sure as of yet). Thees changes resolves the issue.
Summary
🤖 Generated by Copilot at d603153
Refactor and fix module concatenation plugin. Enhance the readability and correctness of the code in
lib/optimize/ModuleConcatenationPlugin.js. Resolve a naming issue that could cause incorrect concatenation. Improve the error messages for unsupported or conflicting modules.Details
🤖 Generated by Copilot at d603153
getIncomingConnectionsmethod and sorting modules by identifier (link)lib/optimize/ModuleConcatenationPlugin.js(link)