Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support [contenthash] template in DllPlugin's name option #16935

Merged
merged 2 commits into from Apr 12, 2023

test: add cases for DllPlugin usage with [contenthash]

fc3bba6
Select commit
Failed to load commit list.
Merged

fix: support [contenthash] template in DllPlugin's name option #16935

test: add cases for DllPlugin usage with [contenthash]
fc3bba6
Select commit
Failed to load commit list.
Deleted GitHub App / Copilot for PRs completed Apr 7, 2023 in 54s

Analysis complete

Summary

This pull request adds a new feature to the LibManifestPlugin that allows using content hashes in DLL plugin names. It also adds a new test case with various types of modules and loaders to verify the feature.

Walkthrough

  • Add contentHashType option to getPath method in LibManifestPlugin to enable content hashes in DLL plugin names (link)
  • Add test files for different types of modules and re-exports to test the DLL plugin with content hashes (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Add custom loader g-loader.js to test the DLL plugin with content hashes and custom loaders (link)
  • Add test.config.js to configure the DLL plugin test case with content hashes and set noTests flag to true (link)

Poem

DLL plugin
Adds contentHashType option
Winter cache is warm

Emoji

📦🔗🧪

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 52.1 seconds
lib/LibManifestPlugin.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/_d.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/_e.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/a.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/b.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/c.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/d.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/e.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/e1.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/e2.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/ee1.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/ee2.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/f.jsx ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/g-loader.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/g.abc.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/h.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/h1.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/ha.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/hb.js ✅ Finished 38.8 seconds
test/configCases/dll-plugin/0-create-dll-with-contenthash/test.config.js ✅ Finished 38.8 seconds
⚠️copilot warnings

⚠️ The "prdescription" command is limited to 20 files by default.

💡 To exclude specific files use exclude: pattern in the configuration.