Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-deterministic moduleId assignment #16933

Merged
merged 7 commits into from Apr 19, 2023
Merged

Fix non-deterministic moduleId assignment #16933

merged 7 commits into from Apr 19, 2023

Commits on Apr 7, 2023

  1. Fix non-deterministic moduleId generation 

    The module sort was encountering NaN values, causing the sort to be non-deterministic, resulting in a different moduleId assignment being used in each build run when moduleIds: "size" is configured.  This causes the build to be slightly different in size each time it's run.
    @scameron
    scameron committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    86f3da4 View commit details
    Browse the repository at this point in the history

  2. Fix lint error (that I disagree with :-) )

    @scameron
    scameron committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    bf7c6d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Add temporary logging to see if repro case already exists in tests

    @scameron
    scameron committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    9ea8630 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Remove temporary logging

    @scameron
    scameron committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c8b3ed7 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. test: added case

    @alexander-akait
    alexander-akait committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    5cc6d13 View commit details
    Browse the repository at this point in the history

  2. chore: fix lint

    @alexander-akait
    alexander-akait committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    90df710 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. chore: fix lint again

    @alexander-akait
    alexander-akait committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    56d4fb2 View commit details
    Browse the repository at this point in the history