Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error message if resolve.extensions is invalid #16807

Merged
merged 3 commits into from Mar 27, 2023
Merged

fix: improve error message if resolve.extensions is invalid #16807

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68f2598
fix: improve error message if `resolve.extensions` is invalid
snitin315 Mar 11, 2023
482ec6d
fix: improve resolve extention hint to be in one line
snitin315 Mar 12, 2023
d9604e9
refactor: move RegExp to a variable and use RegExp.prototype.test()
snitin315 Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions lib/NormalModuleFactory.js
View file
Open in desktop
Expand Up @@ -72,6 +72,7 @@ const EMPTY_GENERATOR_OPTIONS = {};
const EMPTY_ELEMENTS = [];

const MATCH_RESOURCE_REGEX = /^([^!]+)!=!/;
const LEADING_DOT_EXTENSION_REGEX = /^[^.]/;

const loaderToIdent = data => {
if (!data.options) {
Expand Down Expand Up @@ -849,6 +850,25 @@ ${err2.stack}`;
err.message += `
${hints.join("\n\n")}`;
}

// Check if the extension is missing a leading dot (e.g. "js" instead of ".js")
let appendResolveExtensionsHint = false;
const specifiedExtensions = Array.from(
resolver.options.extensions
);
const expectedExtensions = specifiedExtensions.map(extension => {
if (LEADING_DOT_EXTENSION_REGEX.test(extension)) {
appendResolveExtensionsHint = true;
return `.${extension}`;
}
return extension;
});
if (appendResolveExtensionsHint) {
err.message += `\nDid you miss the leading dot in 'resolve.extensions'? Did you mean '${JSON.stringify(
expectedExtensions
)}' instead of '${JSON.stringify(specifiedExtensions)}'?`;
}

callback(err);
}
);
Expand Down