Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #16561 #16562

Merged
merged 12 commits into from Apr 5, 2023
Merged

fix #16561 #16562

merged 12 commits into from Apr 5, 2023

Conversation

long76
Copy link
Contributor

@long76 long76 commented Dec 14, 2022

What kind of change does this PR introduce?
see #16561

Did you add tests for your changes?
no

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?
add globalObject option to page with amd library plugin

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 14, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@webpack-bot
Copy link
Contributor

webpack-bot commented Dec 14, 2022

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@long76
Copy link
Contributor Author

long76 commented Dec 14, 2022

please fix last 2 lint error i worked with ide github

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@long76
Copy link
Contributor Author

long76 commented Dec 19, 2022

Please add tests

ok i need some time

@long76
Copy link
Contributor Author

long76 commented Jan 2, 2023

Please add tests

done, param name changed to amdContainer

@alexander-akait
Copy link
Member

@TheLarkInn Makse sense to look at this too, don't see somethinb bad here

Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution 🚀

@alexander-akait
Copy link
Member

@TheLarkInn Unmerged due 3 failing checks, but there are no problems with other tests

@long76
Copy link
Contributor Author

long76 commented Mar 23, 2023

@TheLarkInn Unmerged due 3 failing checks, but there are no problems with other tests

I can try add more tests for increasing coverage

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 23, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

None yet

4 participants