New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css parser): handle nested atRule #15665
fix(css parser): handle nested atRule #15665
Conversation
|
For maintainers only:
|
c6d59c7
to
811d278
Compare
please accept cla |
@vankop I contacted my company to accept CLA as a Corporate Contributor. I hope this will be done next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs a test case. The example is not enough to test the behavior
811d278
to
cf24c1d
Compare
@noreiller Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
Hello @sokra , thanks for your review, I added some config cases tests. |
cf24c1d
to
7b71e81
Compare
Due to technical issues between the Linux foundation and my company to sign the CLA, I close this PR and created a new one on my personal github. |
Issue:
When using the CSS
experiments
and using@media
or@supports
in CSS code, the nested class names are not replaced with their unique identifier.Changes:
This PR will handle
@media
and@supports
atRule identifiers and enable the replacements of the nested rules names with the unique ids.CSS input code:
The compiled CSS code with the issue:
You can see that only the top-level class name is replaced.
The compiled CSS code thanks to the fix:
You can see that all the class names are replaced.