add extractSourceMap option for modules #15523
Conversation
|
For maintainers only:
|
vankop
force-pushed
the
feat/extract-source-map-plugin
branch
4 times, most recently
from
a936c95
to
85efee7
Compare
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
vankop
force-pushed
the
feat/extract-source-map-plugin
branch
from
7ede1d7
to
059faf8
Compare
vankop
force-pushed
the
feat/extract-source-map-plugin
branch
from
059faf8
to
5931183
Compare
vankop
force-pushed
the
feat/extract-source-map-plugin
branch
3 times, most recently
from
b06b19f
to
b1a7c37
Compare
vankop
changed the title
|
@vankop Can you rebase too? Thank you |
|
Also rebase needed. |
snitin315
force-pushed
the
feat/extract-source-map-plugin
branch
from
82bf50f
to
1539254
Compare
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
snitin315
force-pushed
the
feat/extract-source-map-plugin
branch
from
7444e32
to
a602d8c
Compare
|
@vankop Thanks for your update. I labeled the Pull Request so reviewers will review it again. @TheLarkInn Please review the new changes. |
vankop
force-pushed
the
feat/extract-source-map-plugin
branch
from
ab23406
to
059380c
Compare
| new WebpackError( | ||
| `Failed to parse source map from '${sourceMappingURL}': ${parseError}` | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Based on feedback during development of https://github.com/webpack-contrib/source-map-loader/, better to make an options for this, in real world a lot of packages have broken source maps and developer can't fix it in vendor libraries, so better generate a warning, because it really doesn't break a build, but allow to setup it to make an error, i.e.
type ExtractSourceMap = boolean | { errorSeverity: "none" | "warn" | "error" }| @@ -0,0 +1,3 @@ | |||
| const a = 1; | |||
| // comment | |||
| //#sourceMappingURL=/a.map | |||
There was a problem hiding this comment.
Let's add a test for remote source maps, i.e. http://github.com/webpack/webpack/test/configCases/source-map/my-source-map.js.map
| ); | ||
| } | ||
|
|
||
| if (map.sources && map.sources.length > 0) { |
There was a problem hiding this comment.
Does we support sections? like here https://github.com/webpack-contrib/source-map-loader/blob/master/src/index.js#L91 because I see them sometimes
| return callback(null, input.replace(replacementString, ""), map); | ||
| } | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Also let's implement https://github.com/webpack-contrib/source-map-loader/tree/master?tab=readme-ov-file#filtersourcemappingurl, sometimes some source maps are really broken and you can't do anything with them, so let's add:
type ExtractSourceMap = boolean | { errorSeverity: "...", test: Rules, include: Rules, Exlcude: Rules }
|
Just for infromation we have https://github.com/webpack-contrib/source-map-loader and it works great a lot of time, so maybe some optimizations and inspiration you can take from there |
What kind of change does this PR introduce?
feature
closes #10265
Did you add tests for your changes?
not yet
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
deprecate
source-map-loader