Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass package type to loader runner #15198

Merged
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions declarations/LoaderContext.d.ts
Expand Up @@ -187,6 +187,7 @@ export interface LoaderRunnerLoaderContext<OptionsType> {
data: object | undefined;
pitchExecuted: boolean;
normalExecuted: boolean;
type?: "commonjs" | "module" | undefined;
}[];

/**
Expand Down
14 changes: 12 additions & 2 deletions lib/NormalModuleFactory.js
Expand Up @@ -994,7 +994,7 @@ If changing the source code is not an option there is also a resolve options cal
context,
item.loader,
resolveContext,
(err, result) => {
(err, result, resolveRequest) => {
if (
err &&
/^[^/]*$/.test(item.loader) &&
Expand All @@ -1021,8 +1021,18 @@ If changing the source code is not an option there is also a resolve options cal
if (err) return callback(err);

const parsedResult = this._parseResourceWithoutFragment(result);

const type = /\.mjs$/i.test(parsedResult.loader)
? "module"
: /\.cjs$/i.test(parsedResult.loader)
? "commonjs"
: resolveRequest.descriptionFileData === undefined
? undefined
: resolveRequest.descriptionFileData.type;

const resolved = {
loader: parsedResult.path,
loader: parsedResult.loader,
stefanprobst marked this conversation as resolved.
Show resolved Hide resolved
type,
options:
item.options === undefined
? parsedResult.query
Expand Down
10 changes: 10 additions & 0 deletions test/cases/loaders/cjs-loader-type/index.js
@@ -0,0 +1,10 @@
it("should pass package.json type to loader", function () {
expect(require("cjs/loader.js!")).toBe("commonjs");
expect(require("./loader.js!")).toBe("undefined");
});

it("should pass 'commonjs' type to loader for .cjs", function () {
expect(require("cjs/loader.cjs!")).toBe("commonjs");
expect(require("./loader.cjs!")).toBe("commonjs");
expect(require("esm/loader.cjs!")).toBe("commonjs");
});
4 changes: 4 additions & 0 deletions test/cases/loaders/cjs-loader-type/loader.cjs
@@ -0,0 +1,4 @@
/** @type {import("../../../../").LoaderDefinition} */
module.exports = function loader() {
return `module.exports = "${this.loaders[this.loaderIndex].type}";`;
};
4 changes: 4 additions & 0 deletions test/cases/loaders/cjs-loader-type/loader.js
@@ -0,0 +1,4 @@
/** @type {import("../../../../").LoaderDefinition} */
module.exports = function loader() {
return `module.exports = "${this.loaders[this.loaderIndex].type}";`;
};

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions test/cases/loaders/cjs-loader-type/node_modules/cjs/loader.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions test/cases/loaders/esm-loader-type/index.js
@@ -0,0 +1,9 @@
it("should pass package.json type to loader", function () {
expect(require("esm/loader.js!")).toBe("module");
});

it("should pass 'module' type to loader for .mjs", function () {
expect(require("cjs/loader.mjs!")).toBe("module");
expect(require("esm/loader.mjs!")).toBe("module");
expect(require("./loader.mjs!")).toBe("module");
});
4 changes: 4 additions & 0 deletions test/cases/loaders/esm-loader-type/loader.mjs
@@ -0,0 +1,4 @@
/** @type {import("../../../../").LoaderDefinition} */
export default function loader() {
return `export default "${this.loaders[this.loaderIndex].type}";`;
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions test/cases/loaders/esm-loader-type/node_modules/esm/loader.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions test/cases/loaders/esm-loader-type/test.filter.js
@@ -0,0 +1,5 @@
module.exports = function(config) {
// TODO need fix in v8 https://github.com/nodejs/node/issues/35889
// TODO otherwise this test case cause segment fault
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could filter this spawning another jest process and catching exit code.. but it seems overengineering to me..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this suspect causing the core dumps / Segfault on CI?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes

};
1 change: 1 addition & 0 deletions types.d.ts
Expand Up @@ -6570,6 +6570,7 @@ declare interface LoaderRunnerLoaderContext<OptionsType> {
data?: object;
pitchExecuted: boolean;
normalExecuted: boolean;
type?: "module" | "commonjs";
}[];

/**
Expand Down