First round of tests

Fixing bugs exposed by the tests!

lib/RuntimeTemplate.js

@@ -936,18 +936,17 @@ class RuntimeTemplate {
 			message,
 			chunkName: block.chunkName
 		});
+		const fetchPriority = JSON.stringify(chunkGroup.options.fetchPriority);
 		if (chunks.length === 1) {
 			const chunkId = JSON.stringify(chunks[0].id);
 			runtimeRequirements.add(RuntimeGlobals.ensureChunk);
-			return `${RuntimeGlobals.ensureChunk}(${comment}${chunkId})`;
+			return `${RuntimeGlobals.ensureChunk}(${comment}${chunkId}, ${fetchPriority})`;
 		} else if (chunks.length > 0) {
 			runtimeRequirements.add(RuntimeGlobals.ensureChunk);
 			const requireChunkId = chunk =>
-				`${RuntimeGlobals.ensureChunk}(${JSON.stringify(chunk.id)}, ${
-					chunkGroup.options.fetchPriority
-						? JSON.stringify(chunkGroup.options.fetchPriority)
-						: ""
-				})`;
+				`${RuntimeGlobals.ensureChunk}(${JSON.stringify(
+					chunk.id
+				)}, ${fetchPriority})`;
 			return `Promise.all(${comment.trim()}[${chunks
 				.map(requireChunkId)
 				.join(", ")}])`;

lib/runtime/LoadScriptRuntimeModule.js

@@ -81,7 +81,9 @@ class LoadScriptRuntimeModule extends HelperRuntimeModule {
 			uniqueName
 				? 'script.setAttribute("data-webpack", dataWebpackPrefix + key);'
 				: "",
-			`if(fetchPriority) script.setAttribute("fetchpriority", fetchPriority);`,
+			"if(fetchPriority) {",
+			Template.indent('script.setAttribute("fetchpriority", fetchPriority);'),
+			"}",
 			`script.src = ${
 				this._withCreateScriptUrl
 					? `${RuntimeGlobals.createScriptUrl}(url)`

test/cases/chunks/inline-options/dir14/a.js

@@ -0,0 +1 @@
+export default "a";

test/cases/chunks/inline-options/dir14/b.js

@@ -0,0 +1 @@
+export default "b";

test/cases/chunks/inline-options/dir14/c.js

@@ -0,0 +1 @@
+export default "c";

test/cases/chunks/inline-options/index.js

@@ -180,6 +180,13 @@ if (process.env.NODE_ENV === "production") {
 			}
 		);
 	});
+	it("should be able to load with webpackFetchPriorty high, low and auto", function () {
+		return Promise.all([
+			import(/* webpackFetchPriority: "high"*/ "./dir14/a"),
+			import(/* webpackFetchPriority: "low"*/ "./dir14/b"),
+			import(/* webpackFetchPriority: "auto"*/ "./dir14/c"),
+		])
+	})
 }
 
 function testChunkLoading(load, expectedSyncInitial, expectedSyncRequested) {

test/configCases/web/fetch-priority/a.js

@@ -0,0 +1 @@
+export default "a";

test/configCases/web/fetch-priority/b.js

@@ -0,0 +1,3 @@
+import * as shared from './shared';
+console.log(shared);
+export default "b";

test/configCases/web/fetch-priority/b2.js

@@ -0,0 +1,3 @@
+import * as shared from './shared';
+console.log(shared);
+export default "b";

test/configCases/web/fetch-priority/c.js

@@ -0,0 +1 @@
+export default "c";

test/configCases/web/fetch-priority/d.js

@@ -0,0 +1 @@
+export default "d";

test/configCases/web/fetch-priority/index.js

@@ -0,0 +1,31 @@
+it("should set fetchPriority", () => {
+    // Single Chunk
+    import(/* webpackFetchPriority: "high" */ "./a");
+    expect(document.head._children).toHaveLength(1);
+    const script1 = document.head._children[0];
+    expect(script1._attributes.fetchpriority).toBe("high");
+
+    // Multiple Chunks
+    import(/* webpackFetchPriority: "high" */ "./b");
+    import(/* webpackFetchPriority: "high" */ "./b2");
+    expect(document.head._children).toHaveLength(4);
+    const script2 = document.head._children[1];
+    const script3 = document.head._children[2];
+    const script4 = document.head._children[3];
+    expect(script2._attributes.fetchpriority).toBe("high");
+    expect(script3._attributes.fetchpriority).toBe("high");
+    expect(script4._attributes.fetchpriority).toBe("high");
+
+    // Single Chunk, low
+    import(/* webpackFetchPriority: "low" */ "./c");
+    expect(document.head._children).toHaveLength(5);
+    const script5 = document.head._children[4];
+    expect(script5._attributes.fetchpriority).toBe("low");
+
+    // Single Chunk, auto
+    import(/* webpackFetchPriority: "auto" */ "./d");
+    expect(document.head._children).toHaveLength(6);
+    const script6 = document.head._children[5];
+    expect(script6._attributes.fetchpriority).toBe("auto");
+
+})

test/configCases/web/fetch-priority/shared.js

@@ -0,0 +1 @@
+export default "shared";

test/configCases/web/fetch-priority/webpack.config.js

@@ -0,0 +1,14 @@
+/** @type {import("../../../../").Configuration} */
+module.exports = {
+	target: "web",
+	output: {
+		chunkFilename: "[name].js",
+		crossOriginLoading: "anonymous"
+	},
+	optimization: {
+		minimize: false,
+		splitChunks: {
+			minSize: 1
+		}
+	}
+};