Merge pull request #16944 from snitin315/fix/read-records-callback

fix: handle callback correctly in the `readRecords` compiler hook

lib/Compiler.js

@@ -970,10 +970,13 @@ ${other}`);
 	readRecords(callback) {
 		if (this.hooks.readRecords.isUsed()) {
 			if (this.recordsInputPath) {
-				asyncLib.parallel([
-					cb => this.hooks.readRecords.callAsync(cb),
-					this._readRecords.bind(this)
-				]);
+				asyncLib.parallel(
+					[
+						cb => this.hooks.readRecords.callAsync(cb),
+						this._readRecords.bind(this)
+					],
+					err => callback(err)
+				);
 			} else {
 				this.records = {};
 				this.hooks.readRecords.callAsync(callback);

test/configCases/records/with-readRecords-hook/ReadRecordsPlugin.js

@@ -0,0 +1,12 @@
+class ReadRecordsPlugin {
+	apply(compiler) {
+		compiler.hooks.readRecords.tapAsync("ReadRecordsPlugin", callback => {
+			setTimeout(() => {
+				console.log("Done with reading records.");
+				callback();
+			}, 1000);
+		});
+	}
+}
+
+module.exports = ReadRecordsPlugin;

test/configCases/records/with-readRecords-hook/async.js

@@ -0,0 +1 @@
+import "vendor";

test/configCases/records/with-readRecords-hook/index.js

@@ -0,0 +1,3 @@
+it("should load fine", () => {
+	return import(/* webpackChunkName: "async" */"./async");
+});

test/configCases/records/with-readRecords-hook/records.json

@@ -0,0 +1,10 @@
+{
+  "chunks": {
+    "byName": {
+      "vendors~async": 123
+    },
+    "bySource": {
+      "1 index.js ./async": 123
+    }
+  }
+}

test/configCases/records/with-readRecords-hook/webpack.config.js

@@ -0,0 +1,17 @@
+const path = require("path");
+const ReadRecordsPlugin = require("./ReadRecordsPlugin");
+
+/** @type {import("../../../../").Configuration} */
+module.exports = {
+	entry: "./index",
+	recordsInputPath: path.resolve(__dirname, "records.json"),
+	output: {
+		chunkFilename: "[name]-[chunkhash].js"
+	},
+	plugins: [new ReadRecordsPlugin()],
+	optimization: {
+		splitChunks: {
+			minSize: 0
+		}
+	}
+};