Skip to content

Commit

Permalink
fix: support "..." for resolve importsFields
Browse files Browse the repository at this point in the history
  • Loading branch information
ahabhgk committed Apr 25, 2024
1 parent c586c7b commit 0de9b1d
Show file tree
Hide file tree
Showing 9 changed files with 34 additions and 0 deletions.
1 change: 1 addition & 0 deletions lib/config/defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -1516,6 +1516,7 @@ const getResolveDefaults = ({
exportsFields: ["exports"],
roots: [context],
mainFields: ["main"],
importsFields: ["imports"],
byDependency: {
wasm: esmDeps(),
esm: esmDeps(),
Expand Down
3 changes: 3 additions & 0 deletions test/Defaults.unittest.js
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,9 @@ describe("snapshots", () => {
"exports",
],
"extensions": Array [],
"importsFields": Array [
"imports",
],
"mainFields": Array [
"main",
],
Expand Down
8 changes: 8 additions & 0 deletions test/configCases/resolve-merging/imports-fields/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import d1 from "./pkg.mjs";
import d2 from "#internal";
import { d3, d4 } from "lib";

it("imports field to resolve to the same", () => {
expect(d2).toBe(d1);
expect(d4).toBe(d3);
});

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions test/configCases/resolve-merging/imports-fields/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "pkg",
"imports": {
"#internal": "./pkg.mjs"
}
}
1 change: 1 addition & 0 deletions test/configCases/resolve-merging/imports-fields/pkg.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default 'pkg';
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module.exports = {
entry: "./index.js",
resolve: {
importsFields: ["hash-start", "..."]
}
};

0 comments on commit 0de9b1d

Please sign in to comment.