Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for the extends option #6794

Merged
merged 9 commits into from
May 8, 2023

Conversation

burhanuday
Copy link
Member

@burhanuday burhanuday commented May 1, 2023

describe your changes...

Adds docs for the extends option added to webpack-cli in PR webpack/webpack-cli#3738

  • Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the [writer's guide][2].
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: [Stale Pull Requests][3].

Closes #6801

@vercel
Copy link

vercel bot commented May 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2023 11:05am

@burhanuday
Copy link
Member Author

PR not to be merged until a new release is done for webpack-cli

@vercel
Copy link

vercel bot commented May 3, 2023

@burhanuday is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@burhanuday burhanuday marked this pull request as ready for review May 3, 2023 04:16
@snitin315 snitin315 self-assigned this May 3, 2023
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I'll review this by today/tomorrow.

@burhanuday
Copy link
Member Author

One thing is left to be added. This feature will be supported after the release of webpack and webpack-cli
So as a warning, we need to add the minimum webpack and webpack-cli versions required to use this feature

@burhanuday burhanuday requested a review from snitin315 May 4, 2023 07:13
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, added a few suggestions. Would be great to add an example that shows how we can override a config from the base config.

src/content/configuration/extending-configurations.mdx Outdated Show resolved Hide resolved
src/content/configuration/extending-configurations.mdx Outdated Show resolved Hide resolved
src/content/configuration/extending-configurations.mdx Outdated Show resolved Hide resolved
src/content/configuration/extending-configurations.mdx Outdated Show resolved Hide resolved
src/content/configuration/extending-configurations.mdx Outdated Show resolved Hide resolved
src/content/configuration/extending-configurations.mdx Outdated Show resolved Hide resolved

```javascript
module.exports = {
extends: require.resolve('webpack-config-foo'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need better documentation here on how to create and publish webpack-config-foo. But we can add it later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need better documentation here on how to create and publish webpack-config-foo. But we can add it later.

More work needs to be done here. Ideally, consumers of a config should be able to pass options like we do for plugins.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a new issue for this on the webpack-cli project

@burhanuday
Copy link
Member Author

Looks good overall, added a few suggestions. Would be great to add an example that shows how we can override a config from the base config.

Added a section for this

@burhanuday burhanuday requested a review from snitin315 May 7, 2023 03:54
src/content/api/cli.mdx Outdated Show resolved Hide resolved
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for contributing on this 🚀

@snitin315 snitin315 merged commit e5a74ae into webpack:main May 8, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document webpack change: feat: update webpack types to support extends property in webpack
2 participants