Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(API): add import.meta section #6761

Merged
merged 3 commits into from Apr 18, 2023
Merged

docs(API): add import.meta section #6761

merged 3 commits into from Apr 18, 2023

Conversation

chenxsan
Copy link
Member

Closes #6759

@vercel
Copy link

vercel bot commented Apr 17, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 2:45am

@chenxsan chenxsan added the API label Apr 17, 2023
snitin315
snitin315 reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small suggestion.

src/content/api/module-variables.mdx Outdated Show resolved Hide resolved
@chenxsan @snitin315
Update src/content/api/module-variables.mdx
06bb5eb 
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
@chenxsan chenxsan merged commit ab62912 into webpack:main Apr 18, 2023
9 checks passed
@chenxsan chenxsan deleted the docs/import-meta branch April 18, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 left review comments

Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document webpack change: support destructuring assignment in import.meta
2 participants
@chenxsan @snitin315