Skip to content

Commit 06583f2

Browse files
authoredApr 10, 2020
fix: do not swallow errors from server (#2512)
1 parent 0d5c681 commit 06583f2

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed
 

‎lib/Server.js

+4
Original file line numberDiff line numberDiff line change
@@ -687,6 +687,10 @@ class Server {
687687
} else {
688688
this.listeningApp = http.createServer(this.app);
689689
}
690+
691+
this.listeningApp.on('error', (err) => {
692+
this.log.error(err);
693+
});
690694
}
691695

692696
createSocketServer() {

‎test/server/Server.test.js

+10
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,16 @@ describe('Server', () => {
7676
});
7777
});
7878

79+
it('test listeningApp error reporting', () => {
80+
const logMock = jest.fn();
81+
const compiler = webpack(config);
82+
const server = new Server(compiler, baseDevConfig);
83+
84+
server.log.error = logMock;
85+
86+
server.listeningApp.emit('error', new Error('Error !!!'));
87+
expect(server.log.error).toBeCalledWith(new Error('Error !!!'));
88+
});
7989
// issue: https://github.com/webpack/webpack-dev-server/issues/1724
8090
describe('express.static.mine.types', () => {
8191
it("should success even if mine.types doesn't exist", (done) => {

0 commit comments

Comments
 (0)
Please sign in to comment.