Skip to content

Commit 0d5c681

Browse files
authoredApr 8, 2020
fix(server): don't crash on setupExitSignals(undefined) (#2507)
1 parent c436058 commit 0d5c681

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed
 

‎lib/utils/setupExitSignals.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const signals = ['SIGINT', 'SIGTERM'];
55
function setupExitSignals(serverData) {
66
signals.forEach((signal) => {
77
process.on(signal, () => {
8-
if (serverData.server) {
8+
if (serverData && serverData.server) {
99
serverData.server.close(() => {
1010
// eslint-disable-next-line no-process-exit
1111
process.exit();

‎test/server/utils/setupExitSignals.test.js

+10
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,16 @@ describe('setupExitSignals', () => {
2525
});
2626

2727
signals.forEach((signal) => {
28+
it(`should exit process (${signal}, serverData never defined`, (done) => {
29+
// eslint-disable-next-line no-undefined
30+
setupExitSignals(undefined);
31+
process.emit(signal);
32+
setTimeout(() => {
33+
expect(exitSpy.mock.calls.length).toEqual(1);
34+
done();
35+
}, 1000);
36+
});
37+
2838
it(`should exit process (${signal}, server never defined)`, (done) => {
2939
setupExitSignals({
3040
server: null,

0 commit comments

Comments
 (0)
Please sign in to comment.