Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to jest #379

Merged
merged 39 commits into from
May 17, 2023
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 6, 2023

TODO:

  • Fix failing tests
  • Remove mocha
  • Remove Should

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.74 ⚠️

Comparison is base (4dc1a2f) 94.64% compared to head (beed6bb) 92.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   94.64%   92.90%   -1.74%     
==========================================
  Files          40       43       +3     
  Lines        1624     2029     +405     
  Branches        0      598     +598     
==========================================
+ Hits         1537     1885     +348     
- Misses         87      116      +29     
- Partials        0       28      +28     

see 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait
Copy link
Member

Looks very good, did you look why coverage is now only 81%? I think we have a lot of tests so our coverage should be more...

@snitin315
Copy link
Member Author

@alexander-akait Yes, I'm migrating tests one by one. Once all the tests move to jest, coverage will be more.

@snitin315 snitin315 marked this pull request as ready for review May 14, 2023 02:39
package.json Show resolved Hide resolved
@alexander-akait
Copy link
Member

@snitin315 Ping me when it will be ready, thanks

@snitin315
Copy link
Member Author

@alexander-akait I have migrated all the tests. I think this is ready.

@TheLarkInn TheLarkInn merged commit c9ed069 into webpack:main May 17, 2023
18 of 19 checks passed
@snitin315 snitin315 deleted the feat/migrate-to-jest branch May 17, 2023 15:01
renovate bot added a commit to Unleash/unleash that referenced this pull request Jun 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [enhanced-resolve](https://togithub.com/webpack/enhanced-resolve) |
[`5.14.0` ->
`5.14.1`](https://renovatebot.com/diffs/npm/enhanced-resolve/5.14.0/5.14.1)
|
[![age](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.14.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.14.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.14.1/compatibility-slim/5.14.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.14.1/confidence-slim/5.14.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>webpack/enhanced-resolve</summary>

###
[`v5.14.1`](https://togithub.com/webpack/enhanced-resolve/releases/tag/v5.14.1)

[Compare
Source](https://togithub.com/webpack/enhanced-resolve/compare/v5.14.0...v5.14.1)

#### Bugfixes

- TypeScript `strict` mode is now enabled for `enhanced-resolve` by
[@&#8203;alexander-akait](https://togithub.com/alexander-akait) in
[webpack/enhanced-resolve#381

#### Dependencies & Maintenance

- Migrate to Jest by [@&#8203;snitin315](https://togithub.com/snitin315)
in
[webpack/enhanced-resolve#379
- Bump minimatch from 3.0.4 to 3.1.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[webpack/enhanced-resolve#383
- Add Badges in README by
[@&#8203;snitin315](https://togithub.com/snitin315) in
[webpack/enhanced-resolve#386

**Full Changelog**:
webpack/enhanced-resolve@v5.14.0...v5.14.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

None yet

4 participants