Allow filtering the list of entrypoints #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrogh
commented
Nov 10, 2023
| }; | ||
|
|
||
| componentDidMount() { | ||
| document.addEventListener('click', this.handleClickOutside, true); |
There was a problem hiding this comment.
couldn't use onBlur since clicking an option would hide the list before the click event was fired
gaojude
approved these changes
Nov 10, 2023
valscion
reviewed
Nov 13, 2023
Thanks! Done. |
valscion
approved these changes
Nov 14, 2023
|
Released in v4.10.0! |
huozhi
pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 7, 2024
webpack-contrib/webpack-bundle-analyzer#624 was merged and released in 4.10.0 and I'd like to leverage this change in `@next/bundle-analyzer`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
#622
What does this change do?
Screenshots
Before
Screen.Recording.2023-11-09.at.7.15.13.AM.mov
After
Screen.Recording.2023-11-10.at.10.04.19.AM.mov