Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for importModule function and mode variable #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tarik02
Copy link

@tarik02 tarik02 commented Jun 5, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

I just need those in one of my loaders. And someone also probably need this :D

Breaking Changes

No it probably doesn't

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Tarik02 / name: Taras (2abbbc3)

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good can we add a test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants