Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support function for loader sunch as css-loader #58 #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BUPTlhuanyu
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

#58

function options like getLocalIdent cannot passed to the css-loader,so i need this function without scoped var.

Breaking Changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 19, 2021

CLA Signed

The committers are authorized under a signed CLA.

@BUPTlhuanyu
Copy link
Author

Hello, this issue is a common case

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should apply this logic for all unknown functions?

@BUPTlhuanyu
Copy link
Author

Maybe we should apply this logic for all unknown functions?

The functions with scope vars will case an error, so i take a white list of function-name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants