Skip to content

Commit

Permalink
fix: getLogger not defined in child loader
Browse files Browse the repository at this point in the history
  • Loading branch information
Benjamin Hodgson committed Dec 8, 2021
1 parent 2e1dfff commit d864a0b
Show file tree
Hide file tree
Showing 8 changed files with 529 additions and 1 deletion.
322 changes: 321 additions & 1 deletion package-lock.json

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
"eslint-plugin-import": "^2.22.1",
"husky": "^4.3.0",
"jest": "^26.6.1",
"less-loader": "^10.2.0",
"lint-staged": "^10.5.0",
"lodash": "^4.17.20",
"memfs": "^3.2.0",
Expand Down
19 changes: 19 additions & 0 deletions src/worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,25 @@ const queue = asyncQueue(({ id, data }, taskCallback) => {

return options;
},
getLogger: (name) => {
return {
error(message) {
console.error(`${name}: ${message}`);
},

warn(message) {
console.warn(`${name}: ${message}`);
},

log(message) {
console.log(`${name}: ${message}`);
},

debug(message) {
console.debug(`${name}: ${message}`);
},
};
},
emitWarning: (warning) => {
writeJson({
type: 'emitWarning',
Expand Down
130 changes: 130 additions & 0 deletions test/less-loader-example/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions test/less-loader-example/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"dependencies": {
"lodash-es": "^4.17.14",
"react": "^16.6.3"
}
}
3 changes: 3 additions & 0 deletions test/less-loader-example/style.less
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
body {
background: red;
}
30 changes: 30 additions & 0 deletions test/less-loader-example/webpack.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
const path = require('path');

const MiniCssExtractPlugin = require('mini-css-extract-plugin'); // eslint-disable-line import/no-extraneous-dependencies

module.exports = {
mode: 'none',
context: __dirname,
entry: ['./style.less'],
output: {
path: path.resolve('dist'),
},
module: {
rules: [
{
test: /\.less$/,
use: [
MiniCssExtractPlugin.loader,
path.resolve(__dirname, '../../dist/index.js'),
'css-loader',
'less-loader',
],
},
],
},
plugins: [
new MiniCssExtractPlugin({
filename: 'style.css',
}),
],
};
19 changes: 19 additions & 0 deletions test/webpack.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import webpack from 'webpack';

import sassLoaderConfig from './sass-loader-example/webpack.config';
import lessLoaderConfig from './less-loader-example/webpack.config';

test("Processes sass-loader's @import correctly", (done) => {
const config = sassLoaderConfig({});
Expand All @@ -21,3 +22,21 @@ test("Processes sass-loader's @import correctly", (done) => {
done();
});
}, 30000);

test('Works with less-loader', (done) => {
webpack(lessLoaderConfig, (err, stats) => {
if (err) {
// eslint-disable-next-line no-console
console.error(err);
}

expect(err).toBe(null);

if (stats.hasErrors()) {
// eslint-disable-next-line no-console
console.error(stats.toJson().errors);
}
expect(stats.hasErrors()).toBe(false);
done();
});
}, 30000);

0 comments on commit d864a0b

Please sign in to comment.