Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modern api depedencies #1123

Merged
merged 2 commits into from Mar 18, 2023
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1122

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.51 ⚠️

Comparison is base (de29518) 94.10% compared to head (45f1d4f) 93.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
- Coverage   94.10%   93.60%   -0.51%     
==========================================
  Files           5        5              
  Lines         373      375       +2     
  Branches      137      137              
==========================================
  Hits          351      351              
- Misses         19       20       +1     
- Partials        3        4       +1     
Impacted Files Coverage Δ
src/index.js 92.00% <33.33%> (-8.00%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 21966ee into master Mar 18, 2023
11 of 13 checks passed
@alexander-akait alexander-akait deleted the fix-modern-api-depedencies branch March 18, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom importer in modern api mode may cause ERR_INVALID_URL_SCHEME error.
1 participant