chore: update dependencies to the latest version #1038
Conversation
|
Need fix tests |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1038 +/- ##
==========================================
- Coverage 90.54% 90.31% -0.24%
==========================================
Files 5 5
Lines 857 857
Branches 243 244 +1
==========================================
- Hits 776 774 -2
- Misses 71 73 +2
Partials 10 10
☔ View full report in Codecov by Sentry. |
src/loader.js
Outdated
| @@ -349,6 +349,7 @@ function pitch(request) { | |||
| const outputOptions = { | |||
| filename: childFilename, | |||
| publicPath, | |||
| asyncChunkLoading: false, | |||
There was a problem hiding this comment.
We should not do it or fix it on webpack side
There was a problem hiding this comment.
@alexander-akait will webpack/webpack#17365 fix this ?
There was a problem hiding this comment.
@ersachin3112 I think no
| new NodeTemplatePlugin(outputOptions).apply(childCompiler); | ||
| new NodeTemplatePlugin().apply(childCompiler); |
There was a problem hiding this comment.
@alexander-akait We have only filename and publicPath in outputOptions but the NodeTemplatePlugin only uses asyncChunkLoading. I think don't need to pass it here, TS also warns about the same.
|
Let's fix old API |
This PR contains a:
Motivation / Use-Case
update dependencies to the latest version
Breaking Changes
No
Additional Info
No