Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: minimum supported Node.js version is 18.12.0 #1563

Closed
wants to merge 3 commits into from
Closed

build!: minimum supported Node.js version is 18.12.0 #1563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ace9cc
build!: minimum supported Node.js version is `18.12.0`
snitin315 Jan 14, 2024
d5cf9d1
chore: update deps
snitin315 Jan 16, 2024
f5c2a3f
chore: update snaps
snitin315 Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [12.x, 14.x, 16.x, 18.x, 20.x]
node-version: [18.x, 20.x, 21.x]
webpack-version: [latest]

runs-on: ${{ matrix.os }}
Expand Down
13 changes: 7 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ type importFn =
media: string,
resourcePath: string,
supports?: string,
layer?: string
layer?: string,
) => boolean;
};
```
Expand Down Expand Up @@ -315,7 +315,7 @@ type modules =
getLocalIdent: (
context: LoaderContext,
localIdentName: string,
localName: string
localName: string,
) => string;
namedExport: boolean;
exportGlobals: boolean;
Expand Down Expand Up @@ -1072,7 +1072,7 @@ Type:
type getLocalIdent = (
context: LoaderContext,
localIdentName: string,
localName: string
localName: string,
) => string;
```

Expand Down Expand Up @@ -1309,7 +1309,7 @@ module.exports = {
name.replace(/-/g, "_"),
// dashesCamelCase
name.replace(/-+(\w)/g, (match, firstLetter) =>
firstLetter.toUpperCase()
firstLetter.toUpperCase(),
),
];
},
Expand Down Expand Up @@ -1746,7 +1746,8 @@ With the help of the `/* webpackIgnore: true */`comment, it is possible to disab
.class {
/* Disabled url handling for the second url in the 'background' declaration */
color: red;
background: url("./url/img.png"),
background:
url("./url/img.png"),
/* webpackIgnore: true */ url("./url/img.png");
}

Expand Down Expand Up @@ -1880,7 +1881,7 @@ module.exports = {
alias: {
"/assets/unresolved/img.png": path.resolve(
__dirname,
"assets/real-path-to-img/img.png"
"assets/real-path-to-img/img.png",
),
},
},
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = (api) => {
"@babel/preset-env",
{
targets: {
node: "12.13.0",
node: "18.12.0",
},
},
],
Expand Down