Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: minimum supported Nodejs version is 14.15.0 #1505

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

snitin315
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Update Nodejs

Breaking Changes

minimum supported Nodejs version is 14.15.0

Additional Info

Let's update dependencies separate.

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (175729a) 96.81% compared to head (393ec87) 96.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1505   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          12       12           
  Lines        1131     1131           
  Branches      411      411           
=======================================
  Hits         1095     1095           
  Misses         27       27           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I think we have some TODOs here, do you want to help me solve them?

@snitin315
Copy link
Member Author

@alexander-akait sure, let me know about them. Also, can we directly merge this into master?

@alexander-akait
Copy link
Member

Let's look how many issuea we have, maybe we can do it just in couple PRs and we will merge them together or I can merge them into the next branch, dependes how you prefer

@snitin315 snitin315 changed the base branch from master to next-v7 March 29, 2023 03:33
@snitin315
Copy link
Member Author

@alexander-akait let's use the next-v7 branch.

@alexander-akait alexander-akait merged commit 12a8704 into next-v7 Mar 29, 2023
@alexander-akait alexander-akait deleted the node-14 branch March 29, 2023 07:45
@alexander-akait
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants