feat: add one-letter-css plugin #1181
Conversation
Codecov ReportBase: 96.81% // Head: 98.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
==========================================
+ Coverage 96.81% 98.83% +2.01%
==========================================
Files 12 12
Lines 1131 773 -358
Branches 411 236 -175
==========================================
- Hits 1095 764 -331
+ Misses 27 9 -18
+ Partials 9 0 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/plugins/hash-len-suggest.js
Outdated
|
|
||
| console.log(); | ||
| console.log('Suggest Minify Plugin'); | ||
| console.log('Matched length (len: number):', matchLen); |
There was a problem hiding this comment.
We have logger for webpack, avoid using console.log https://webpack.js.org/api/logging/
src/plugins/hash-len-suggest.js
Outdated
| }); | ||
|
|
||
| return matchLen; | ||
| } |
There was a problem hiding this comment.
We should use weak cache here, otherwise is was memory leak in watch mode
src/plugins/hash-len-suggest.js
Outdated
| } | ||
| } | ||
|
|
||
| module.exports = HashLenSuggest; |
There was a problem hiding this comment.
I think we can avoid using plugin, we have the identifier of module, so we can generate names based on this
There was a problem hiding this comment.
we use file path to make long cash. and make shortest hash as we can (but need check for collisions)
| this.a = 'a'.charCodeAt(0); | ||
| this.A = 'A'.charCodeAt(0); | ||
| // file hashes cache | ||
| this.files = {}; |
There was a problem hiding this comment.
Here potential memory leak in watch mode, if will have a lot of renamed files, the object will grow
# Conflicts: # src/plugins/index.js
|
Is this dead? |
This PR contains a:
resolve issue #1028
For efficient gzip/br compression, plugin combine css hash via one symbol name,
as a classname position at file, with filepath hash:base64:8, to have strong sequences.