-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): use -- for selenium args in Selenium Standalone Service #9969
Conversation
|
@@ -71,7 +71,7 @@ export const config = { | |||
logPath: './temp', | |||
args: { | |||
version: "3.141.59", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version should be bumped to v4 if you want to make this a v4 example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also baseURL (https://github.com/SeleniumHQ/selenium/releases/download) and https://github.com/webdriverio/selenium-standalone/blob/HEAD/docs/API.md#seleniuminstallopts (contains link to old https://selenium-release.storage.googleapis.com/index.html) need to be updated, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would be great!
@manuelfidalgo any chance you are able to address the issue? |
I'm quite busy these days, I'll give it a try next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks 👍
Congratulations on your first WebdriverIO contribution! This project can't live without the participation of the community. We would love to see more from you, so let us know if we can help to find interesting areas for you to contribute to. We appreciate you 🙏 ❤️ |
@christian-bromann , I updated selenium & driver versions. No need to change download url. since they are correct |
Proposed changes
After Selenium4, "--" is used to specify selenium args instead of "-"
If you use just "-", no parse args error is thrown but args are not taken into account, so I think is better to use "--" to match latest Selenium versions
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers