Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): use -- for selenium args in Selenium Standalone Service #9969

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

manuelfidalgo
Copy link
Contributor

@manuelfidalgo manuelfidalgo commented Mar 14, 2023

Proposed changes

After Selenium4, "--" is used to specify selenium args instead of "-"
If you use just "-", no parse args error is thrown but args are not taken into account, so I think is better to use "--" to match latest Selenium versions

Types of changes

  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: manuelfidalgo / name: Manuel Fidalgo Sicilia (1386c4e)

@@ -71,7 +71,7 @@ export const config = {
logPath: './temp',
args: {
version: "3.141.59",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version should be bumped to v4 if you want to make this a v4 example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be great!

@christian-bromann
Copy link
Member

@manuelfidalgo any chance you are able to address the issue?

@manuelfidalgo
Copy link
Contributor Author

@manuelfidalgo any chance you are able to address the issue?

I'm quite busy these days, I'll give it a try next week

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks 👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Apr 24, 2023
@christian-bromann christian-bromann merged commit 70cb14b into webdriverio:main Apr 24, 2023
3 checks passed
@christian-bromann
Copy link
Member

Congratulations on your first WebdriverIO contribution! This project can't live without the participation of the community. We would love to see more from you, so let us know if we can help to find interesting areas for you to contribute to. We appreciate you 🙏 ❤️

@manuelfidalgo
Copy link
Contributor Author

@manuelfidalgo any chance you are able to address the issue?

I'm quite busy these days, I'll give it a try next week

@christian-bromann , I updated selenium & driver versions. No need to change download url. since they are correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants