Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdio-config: Add multi-run cli flag #9947

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

WillBrock
Copy link
Member

Proposed changes

Implements 9926

I noticed some of the other cli flags do camel case so we could change it from --mulit-run to --multiRun or a new name all together.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@WillBrock
Copy link
Member Author

It doesn't look like the Windows failed test is from this change.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM 👍

packages/wdio-config/src/lib/ConfigParser.ts Outdated Show resolved Hide resolved
@christian-bromann
Copy link
Member

@WillBrock can we maybe add a section to https://webdriver.io/docs/retry that touches on this practice of detecting flaky tests? It might help people to understand what the flag is suppose to do. I am open for other locations in the docs for it.

@WillBrock
Copy link
Member Author

Updated the Retry.md doc.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants