-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix skip test filename #12675
Fix skip test filename #12675
Conversation
A describe block is mandatory right now afaik and I do not think you can run without it. Are you able to run a "it" block that does not have a "describe" block after patching this locally? |
@erwinheitzman Yes I am able to run without describe block. My test file looks like below
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Can we raise a similar PR to the main
branch?
I think technically a describe
block is not needed but I am sure it will cause issues with many reporters in the WDIO ecosystem, which is why I would recommend to have them. Regardless, I think it is fine to move forward with this change.
@christian-bromann @erwinheitzman Any plans for release of v8 and v7 in near future? |
Yes, looking into that right now. |
* fix: skip test file outside describe block * chore: null check
Proposed changes
If no describe block present, onSuiteStart doesn't get called. This sends filename as undefined to browserstack observability. Use specs list for filename
//: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.)
Types of changes
Checklist
Backport Request
//: # (The current
main
branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8
branch.)v9
and doesn't need to be back-ported#XXXXX
Further comments
Reviewers: @webdriverio/project-committers