Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(wdio-browser-runner): fix error response for the wdio-browser-runner #12540

Merged
merged 2 commits into from
Mar 21, 2024
Merged

(wdio-browser-runner): fix error response for the wdio-browser-runner #12540

merged 2 commits into from
Mar 21, 2024

Conversation

erwinheitzman
Copy link
Member

Proposed changes

Backport of #12539

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@erwinheitzman erwinheitzman mentioned this pull request Mar 21, 2024
Merged
13 tasks
@erwinheitzman erwinheitzman added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 21, 2024
christian-bromann
christian-bromann approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@erwinheitzman erwinheitzman merged commit afe8c68 into webdriverio:v8 Mar 21, 2024
7 of 8 checks passed
JohnJoser3 pushed a commit to JohnJoser3/webdriverio-browserstack-docs that referenced this pull request May 3, 2024
@erwinheitzman @JohnJoser3
(wdio-browser-runner): fix error response for the wdio-browser-runner (…
e85ede7 
…webdriverio#12540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erwinheitzman @christian-bromann