-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(scripts): migrate AWS SDK for JavaScript v2 APIs to v3 #11587
(scripts): migrate AWS SDK for JavaScript v2 APIs to v3 #11587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see the SDK supporting promises 🙌
LGTM 👍
@trivikr thanks for raising the PR and helping to transition to the new major version. Really appreciate it! |
I am seeing some issues deploying the docs:
Any idea what that could be? |
throw new Error("Region is missing");
^ How was region set earlier in JS SDK v2? The S3 client is created without any configuration in source code webdriverio/scripts/updateDocs.js Line 27 in 81496a3
The infrastructure might be setting region somewhere else, like in |
Good question, it seems like it wasn't set before at all. |
Found another issue 😉 a64ed86#diff-b5dd452c7b25cc1278ad2baf3ac8c31e2348b59ebba6eab66655722917a98c47R38 |
Proposed changes
This PR migrates AWS SDK for JavaScript v2 APIs to v3 in scripts
From AWS SDK for JavaScript v2 README:
Types of changes
Updating scripts
Checklist
Further comments
Reviewers: @webdriverio/project-committers