Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@wdio/globals): fix type reference annotation #11524

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

christian-bromann
Copy link
Member

Proposed changes

For some reason TypeScript doesn't keep the type annotation comment in packages/wdio-globals/src/index.ts in the first line. After compiling the package it becomes:

/// <reference types="./standalone.js" />
/// <reference types="types.js" />

Which can't get resolved by TypeScript. Instead we want the original annotation comment to be kept.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 25, 2023
@christian-bromann christian-bromann merged commit abb33f0 into main Oct 25, 2023
8 checks passed
@christian-bromann christian-bromann deleted the cb/globals-type-fix branch October 25, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant