-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(@wdio/utils): Add envDetector for browserstack #11509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If capabilities['bstack:options'].platformName
is a thing we should extend the BrowserStackCapabilities type
export interface BrowserStackCapabilities { |
Ok, I added this to BSCapabilities |
Ok I fixed all ""blank"" properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Congratulations on your remarkable first contribution to WebdriverIO! This project thrives on the invaluable involvement of our community, and we are truly grateful for your contribution. We eagerly anticipate witnessing more of your exceptional work, so please don't hesitate to inform us if we can assist you in identifying intriguing areas where you can make further contributions. Join our lively Discord channel and reach out to us; we would be delighted to connect with you. Your efforts are deeply appreciated, and we extend our heartfelt gratitude to you. 🙏 ❤️ |
fixes #11474 |
Thank you very much, as a mobile tester automater, I choose wdio + appium for my project! Good job! :P |
Proposed changes
//: # I fix the bug that doesn't allow to check isMobile, isAndroid, isIOS command in browserstack
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers