Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@wdio/utils): Add envDetector for browserstack #11509

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

Pi-fe
Copy link
Contributor

@Pi-fe Pi-fe commented Oct 23, 2023

Proposed changes

//: # I fix the bug that doesn't allow to check isMobile, isAndroid, isIOS command in browserstack

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/wdio-utils/src/envDetector.ts Outdated Show resolved Hide resolved
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Oct 23, 2023
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If capabilities['bstack:options'].platformName is a thing we should extend the BrowserStackCapabilities type

export interface BrowserStackCapabilities {
.

@Pi-fe
Copy link
Contributor Author

Pi-fe commented Oct 24, 2023

If capabilities['bstack:options'].platformName is a thing we should extend the BrowserStackCapabilities type

export interface BrowserStackCapabilities {

.

Ok, I added this to BSCapabilities

@Pi-fe
Copy link
Contributor Author

Pi-fe commented Oct 25, 2023

Ok I fixed all ""blank"" properties

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing types

packages/wdio-utils/src/envDetector.ts Outdated Show resolved Hide resolved
packages/wdio-utils/src/envDetector.ts Outdated Show resolved Hide resolved
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 5a9c5a7 into webdriverio:main Oct 25, 2023
7 of 8 checks passed
@christian-bromann
Copy link
Member

Congratulations on your remarkable first contribution to WebdriverIO! This project thrives on the invaluable involvement of our community, and we are truly grateful for your contribution. We eagerly anticipate witnessing more of your exceptional work, so please don't hesitate to inform us if we can assist you in identifying intriguing areas where you can make further contributions. Join our lively Discord channel and reach out to us; we would be delighted to connect with you. Your efforts are deeply appreciated, and we extend our heartfelt gratitude to you. 🙏 ❤️

@christian-bromann
Copy link
Member

fixes #11474

@Pi-fe
Copy link
Contributor Author

Pi-fe commented Oct 25, 2023

Congratulations on your remarkable first contribution to WebdriverIO! This project thrives on the invaluable involvement of our community, and we are truly grateful for your contribution. We eagerly anticipate witnessing more of your exceptional work, so please don't hesitate to inform us if we can assist you in identifying intriguing areas where you can make further contributions. Join our lively Discord channel and reach out to us; we would be delighted to connect with you. Your efforts are deeply appreciated, and we extend our heartfelt gratitude to you. 🙏 ❤️

Thank you very much, as a mobile tester automater, I choose wdio + appium for my project!
Every time I'll have a suggestion or problem I'll write on github or discord or I try to fix.

Good job! :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants