(webdriverio): fix - scrollIntoView calls scroll action with a wrong …

[ghost]

Proposed changes

From the last improvement in the function, a bad argument is sent to the scroll action. We should not use deltaX value into x argument.

This fixes #11272

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Checklist

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• I have added proper type definitions for new commands (if appropriate)

Further comments

I tested in a local project but I wasn't sure how to add or update existing tests inside webdriverio project. I was not able to reproduce the issue with existing tests but with my own.
Here is the test I used to see the log disappeared.

The fix should be also testable using example provided in the initial ticket description by Lara.

Reviewers: @webdriverio/project-committers

@erwinheitzman since you worked in it recently

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: qaflorent (a103bc1, 09fa691)

[christian-bromann]

LGTM 👍

@erwinheitzman what do you think?

[erwinheitzman]

Thank you for your contribution, LGTM 👍

[christian-bromann]

@qaflorent mind updating the snapshots and make the tests pass?

[ghost]

@qaflorent mind updating the snapshots and make the tests pass?

Of course, sorry I missed that. Should be good now.

[christian-bromann]

Tests are failing for different reasons. I will go ahead and merge this one and fix the tests in main.

[christian-bromann]

Congratulations @qaflorent on your remarkable first contribution to WebdriverIO! This project thrives on the invaluable involvement of our community, and we are truly grateful for your contribution. We eagerly anticipate witnessing more of your exceptional work, so please don't hesitate to inform us if we can assist you in identifying intriguing areas where you can make further contributions. Join our lively Discord channel and reach out to us; we would be delighted to connect with you. Your efforts are deeply appreciated, and we extend our heartfelt gratitude to you. 🙏 ❤️

[forPetProject]

Congratulations @qaflorent on your remarkable first contribution to WebdriverIO! This project thrives on the invaluable involvement of our community, and we are truly grateful for your contribution. We eagerly anticipate witnessing more of your exceptional work, so please don't hesitate to inform us if we can assist you in identifying intriguing areas where you can make further contributions. Join our lively Discord channel and reach out to us; we would be delighted to connect with you. Your efforts are deeply appreciated, and we extend our heartfelt gratitude to you. 🙏 ❤️

Could you please help understand in which version this will be delivered?

[ghost]

Could you please help understand in which version this will be delivered?

It should be delivered in 8.21.0, but it seems the fix is not sufficient/good. I still have big troubles to test it (trying and trying again locally), but @erwinheitzman , I would like to try replacing .scroll({ duration: 0, x: deltaX, y: deltaY, origin: this }) with .scroll({ duration: 0, deltaX, deltaY, origin: this }) as I originally thought.

[christian-bromann]

@qaflorent you can make the change directly in your node_modules to test it in your project.