Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue 9578 #11464

Merged
merged 22 commits into from
Nov 6, 2023
Merged

Conversation

KierenLWoods
Copy link
Contributor

@KierenLWoods KierenLWoods commented Oct 18, 2023

Proposed changes

This change fixes #9578 . There was an issue where if a user answered the test file generation location questions with a response such as 'y', the wizard would then put all the files in the current directory. With this fix even if 'y' was to be passed the files would then be generated in a folder named y under the project root. This PR also fixes a bug around the step definition file location.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

fixes #9578

Reviewers: @webdriverio/project-committers

packages/wdio-cli/src/utils.ts Outdated Show resolved Hide resolved
packages/wdio-cli/src/utils.ts Outdated Show resolved Hide resolved
packages/wdio-cli/src/commands/config.ts Outdated Show resolved Hide resolved
packages/wdio-cli/src/utils.ts Outdated Show resolved Hide resolved
@christian-bromann
Copy link
Member

@KierenLWoods it seems like that there are still two snapshots that need to be updated.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great work! LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 6, 2023
@christian-bromann christian-bromann merged commit 921359f into webdriverio:main Nov 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Configuration wizard: validate relative path for specs/feature files and page objects
4 participants