[browserstack-service] Sending skipped test details for beforeEach, beforeAll and afterEach hooks in mocha #10258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added observability and browserstack check
8 tasks
|
@christian-bromann Please review this PR |
8 tasks
| let parentTitle = test.parent | ||
| // Sometimes parent will be an object instead of a string | ||
| if (typeof test.parent === 'object') { | ||
| // @ts-ignore |
There was a problem hiding this comment.
Can we resolve the type issue?
There was a problem hiding this comment.
Actually, we are getting the test object from the context of the test that is passed to the service (test.ctx.test.parent) in some places. And this object doesn't match with Framework.Test type which has parent has string, but in the context object, the parent can be an object. Also we don't have any exported types to type for this context.
Currently removed the ts-ignore and casted it to any. Let me know if you have any better solution
|
@christian-bromann the tests have passed. Please merge if it looks good to you. |
christian-bromann
added
the
PR: Polish 💅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related v7 PR #10259
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers