-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added histroy and testcaseid #10053
Added histroy and testcaseid #10053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epszaw is there a way to set these information without setting a private property?
Yes. If you talk about unit tests, it's possible to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
@BorisOsipov made the changes thank you so much could you have a look |
@@ -26,6 +26,7 @@ import type { | |||
import { | |||
TYPE as DescriptionType | |||
} from './types.js' | |||
import { md5 } from 'allure-js-commons' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already import allure-js-commons
at the top, so let's add md5
to it.
@praveendvd Looks good. It seems that it would be nice to add unit tests for these changes to avoid any potential regressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to include this into the next release so I will go ahead and merge it.
Thanks @praveendvd for the fix 👍
It seems that it would be nice to add unit tests for these changes to avoid any potential regressions.
I will add unit tests for it.
Proposed changes
Allure checks if a test case is unique by using history and testcaseid , so exiplicitly added cid as these ids
fix for #9993
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers