Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added histroy and testcaseid #10053

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Added histroy and testcaseid #10053

merged 3 commits into from
Apr 5, 2023

Conversation

praveendvd
Copy link
Contributor

@praveendvd praveendvd commented Mar 26, 2023

Proposed changes

Allure checks if a test case is unique by using history and testcaseid , so exiplicitly added cid as these ids

fix for #9993

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epszaw is there a way to set these information without setting a private property?

@epszaw
Copy link
Contributor

epszaw commented Mar 27, 2023

@epszaw is there a way to set these information without setting a private property?

Yes. If you talk about unit tests, it's possible to use getResults (packages/wdio-allure-reporter/tests/helpers/wdio-allure-helper.ts) utility to read test results as plain json. I guess, the parameters should be present.

Copy link
Member

@BorisOsipov BorisOsipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@praveendvd
Copy link
Contributor Author

@BorisOsipov made the changes thank you so much could you have a look

@@ -26,6 +26,7 @@ import type {
import {
TYPE as DescriptionType
} from './types.js'
import { md5 } from 'allure-js-commons'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already import allure-js-commons at the top, so let's add md5 to it.

@BorisOsipov
Copy link
Member

@praveendvd Looks good. It seems that it would be nice to add unit tests for these changes to avoid any potential regressions.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to include this into the next release so I will go ahead and merge it.
Thanks @praveendvd for the fix 👍

It seems that it would be nice to add unit tests for these changes to avoid any potential regressions.

I will add unit tests for it.

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 5, 2023
@christian-bromann christian-bromann merged commit 44e65cb into main Apr 5, 2023
6 checks passed
@christian-bromann christian-bromann deleted the allureretry-praveen branch April 5, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants