This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add accout.signRaw function to sign a message without prefix #7346
Merged
+239
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7346 +/- ##
=======================================
Coverage 94.50% 94.51%
=======================================
Files 217 217
Lines 8487 8491 +4
Branches 2343 2345 +2
=======================================
+ Hits 8021 8025 +4
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more. |
jdevcs
reviewed
Oct 22, 2024
jdevcs
reviewed
Oct 22, 2024
e1cc627
to
32c9f3c
Compare
jdevcs
approved these changes
Oct 24, 2024
jdevcs
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackmoshui thanks |
Added. 😄 Thanks for the reminder. |
avkos
approved these changes
Oct 28, 2024
danforbes
approved these changes
Oct 28, 2024
@blackmoshui before merging this PR, there are merge conflicts needs to be fixed, thanks |
Updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #6955
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.