Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Restructure Docs #7298

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Restructure Docs #7298

merged 3 commits into from
Oct 7, 2024

Conversation

danforbes
Copy link
Contributor

@danforbes danforbes commented Oct 3, 2024

  • Created two new sections: Transactions and dApps
  • Moved information about transactions from Accounts & Wallets section to new Transactions section
  • Moved information about MetaMask and WalletConnect from Accounts & Wallets section to new dApps section
  • Sections that only have one page no longer collapse
  • Renamed directories so that they sort in the same order as the sidebar of the rendered docs

Copy link

github-actions bot commented Oct 3, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.81 kB → 640.81 kB (-2 B) -0.00%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
../lib/commonjs/types.d.ts 2.67 kB → 2.67 kB (-2 B) -0.07%

Unchanged

Asset File Size % Changed
web3.min.js 621.32 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: ded11db Previous: 7c207b8 Ratio
processingTx 21954 ops/sec (±6.77%) 20590 ops/sec (±8.07%) 0.94
processingContractDeploy 38025 ops/sec (±8.49%) 39585 ops/sec (±5.47%) 1.04
processingContractMethodSend 14904 ops/sec (±8.43%) 14808 ops/sec (±10.80%) 0.99
processingContractMethodCall 26680 ops/sec (±7.00%) 27609 ops/sec (±6.88%) 1.03
abiEncode 41335 ops/sec (±7.04%) 42563 ops/sec (±7.37%) 1.03
abiDecode 29336 ops/sec (±6.45%) 28955 ops/sec (±7.81%) 0.99
sign 1504 ops/sec (±3.88%) 1499 ops/sec (±3.09%) 1.00
verify 358 ops/sec (±0.68%) 362 ops/sec (±0.59%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@danforbes danforbes force-pushed the chore/docs/restructure branch from 2e4a075 to 05723f3 Compare October 3, 2024 21:35
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (7c207b8) to head (ded11db).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7298   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files         216      216           
  Lines        8463     8463           
  Branches     2339     2339           
=======================================
  Hits         7993     7993           
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Copy link

@Elenore23 Elenore23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx very nice and easy explain what is my next step, thx to all who care for one soul like me..community is the best...

@jdevcs
Copy link
Contributor

jdevcs commented Oct 7, 2024

preview: https://75b1396d.web3-js-docs.pages.dev/ for other team members

@jdevcs
Copy link
Contributor

jdevcs commented Oct 7, 2024

@danforbes could you add task for this in sprint, thanks

@danforbes danforbes linked an issue Oct 7, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure Docs
4 participants