-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Conversation
danforbes
commented
Oct 3, 2024
•
edited
Loading
edited
- Created two new sections: Transactions and dApps
- Moved information about transactions from Accounts & Wallets section to new Transactions section
- Moved information about MetaMask and WalletConnect from Accounts & Wallets section to new dApps section
- Sections that only have one page no longer collapse
- Renamed directories so that they sort in the same order as the sidebar of the rendered docs
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: ded11db | Previous: 7c207b8 | Ratio |
---|---|---|---|
processingTx |
21954 ops/sec (±6.77% ) |
20590 ops/sec (±8.07% ) |
0.94 |
processingContractDeploy |
38025 ops/sec (±8.49% ) |
39585 ops/sec (±5.47% ) |
1.04 |
processingContractMethodSend |
14904 ops/sec (±8.43% ) |
14808 ops/sec (±10.80% ) |
0.99 |
processingContractMethodCall |
26680 ops/sec (±7.00% ) |
27609 ops/sec (±6.88% ) |
1.03 |
abiEncode |
41335 ops/sec (±7.04% ) |
42563 ops/sec (±7.37% ) |
1.03 |
abiDecode |
29336 ops/sec (±6.45% ) |
28955 ops/sec (±7.81% ) |
0.99 |
sign |
1504 ops/sec (±3.88% ) |
1499 ops/sec (±3.09% ) |
1.00 |
verify |
358 ops/sec (±0.68% ) |
362 ops/sec (±0.59% ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
2e4a075
to
05723f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7298 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 216 216
Lines 8463 8463
Branches 2339 2339
=======================================
Hits 7993 7993
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
05723f3
to
59c7469
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx very nice and easy explain what is my next step, thx to all who care for one soul like me..community is the best...
preview: https://75b1396d.web3-js-docs.pages.dev/ for other team members |
@danforbes could you add task for this in sprint, thanks |